-
Notifications
You must be signed in to change notification settings - Fork 843
Fix setting of HSL values from hexa input #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change setHexa to use updateHSX instead of RGBtoHSV as wasn't updating properly when format was set to HSL
Hi @bytesnz - thanks a lot for the submission, I don't see the difference with the changes. Would you mind adding some steps to reproduce so I can follow along? Thanks a lot! :) |
Took a bit to figure out/remember what the problem was. When you change the hex value in the input box, the lightness value doesn't get updated To replicate:
Observed:
Expected: |
Code has been updated since I committed, so there is a conflict now. Will update it. |
Thanks a lot for coming back to it and giving some context. I'll wait for your updates re: merge conflict, feel free to ping me for a look when you're ready |
Merged 🙂 |
Thanks @bytesnz - I'm going to take a look again shortly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good, tnx, I tested with:
#8471BB
#805BEF
#000000
#FF0000
And I can confirm the Lightness value is being updated properly.
Thank you @bytesnz for your fix - I'm glad it could land eventually :)
Awesome. Thanks @bsmth 🎉 |
I noticed there was an issue setting the saturation and lightness values when a hexa value is input into the hexa input when the color format was set to HSL.
Simple fix of changing
setHexa()
to useupdateHSX()
instead ofRGBtoHSV()
.