Skip to content

Minor: updates specificity weights to reflect updated tutorial. Add cascade file #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 22, 2022

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 9, 2022

Currently updating /en-US/docs/Learn/CSS/Building_blocks/Cascade_and_inheritance. This update reflects the change in that tutorial

@estelle estelle marked this pull request as draft June 9, 2022 02:25
@estelle
Copy link
Member Author

estelle commented Jun 9, 2022

mdn/content#17118

@estelle estelle marked this pull request as ready for review June 9, 2022 22:16
@estelle estelle changed the title Minor: updates specificity weights to reflect updated tutorial Minor: updates specificity weights to reflect updated tutorial. Add cascade file Jun 13, 2022
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the 'specificity' typo, it is quite a tongue-twister as well 🙂

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle estelle requested a review from dipikabh June 14, 2022 17:18
estelle added a commit to mdn/content that referenced this pull request Jun 14, 2022
reliant on mdn/css-examples#77 being merged.
@teoli2003
Copy link
Contributor

@estelle: can you resolve the conflict here? That way @dipikabh can re-review it, then merge it.

For the moment we have a 404 on MDN, and this leads to some confusion.

When this PR lands, it will fix mdn/content#17456

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to number the examples (sorry, I just realized that this review had been sitting as 'Pending')

estelle and others added 2 commits June 22, 2022 06:30
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @estelle!

@dipikabh dipikabh merged commit 73d4826 into mdn:main Jun 22, 2022
dipikabh added a commit to mdn/content that referenced this pull request Jun 29, 2022
* Minor: update task

reliant on mdn/css-examples#77 being merged.

* Update files/en-us/learn/css/building_blocks/cascade_tasks/index.md

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants