accumulate generated css styles for imported/required css files #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did a followup on #6 It works for my usage, and given the tests, it seems it works in other cases. WDYT? |
0135ce4 to
79352f5
Compare
| @@ -108,6 +185,9 @@ export default function transformCssModules({ types: t }) { | |||
| } | |||
| }); | |||
|
|
|||
| // wrap or define processCss function that collect generated css | |||
| currentConfig.processCss = pushStylesCreator(currentConfig.processCss); | |||
There was a problem hiding this comment.
Are we sure that processCss is not transforming css in some way and returns it? Because if so then we need to update pushStylesCreator to reflect those changes before css is passed to extractCssFile.
There was a problem hiding this comment.
Indeed.
I updated pushStylesCreator to use processCss return value if it is a string.
|
Great PR, thank you! 👍 There is only this one question from me. When we'll be sure that |
79352f5 to
072fffc
Compare
Fixes michalkvasnicak#5 Replaces michalkvasnicak#6 It is helpful to release a library that uses css-modules. To combine all css files in a single file, give its name: ``` { "plugins": [ [ "css-modules-transform", { "extractCss": "./dist/stylesheets/combined.css" } ] ] } ``` To extract all files in a single directory, give an object: ``` { "plugins": [ [ "css-modules-transform", { "extractCss": { dir: "./dist/stylesheets/", relativeRoot: "./src/", filename: "[path]/[name].css" } } ] ] } ```
072fffc to
18118ae
Compare
|
@themouette thank you 👍 |
|
Released as |
|
\o/ |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
Replaces #6
It is helpful to release a library that uses css-modules.
To combine all css files in a single file, give its name:
To extract all files in a single directory, give an object: