Skip to content

Cache and circular deps #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2017
Merged

Cache and circular deps #38

merged 3 commits into from
Mar 21, 2017

Conversation

michalkvasnicak
Copy link
Owner

Fixes #35, #33

Also fixes problems with circular dependencies when used with babel-node and babel-register, #35

Also this provides functionality to use watch mode, only thing a developer has to do is to enable devMode, #33
@hardchor
Copy link

Hey @michalkvasnicak , I guess you already accidentally published to npm. However, since 1.2.3 I'm now getting:

TypeError: /path/to/my/project/src/shared/components/Header/index.jsx: Cannot read property 'extractCss' of undefined
    at PluginPass.post (/path/to/my/project/node_modules/babel-plugin-css-modules-transform/build/index.js:158:34)
    at File.call (/path/to/my/project/node_modules/babel-core/lib/transformation/file/index.js:628:18)
    at File.transform (/path/to/my/project/node_modules/babel-core/lib/transformation/file/index.js:551:12)
    at /path/to/my/project/node_modules/babel-core/lib/transformation/pipeline.js:50:19
    at File.wrap (/path/to/my/project/node_modules/babel-core/lib/transformation/file/index.js:564:16)
    at Pipeline.transform (/path/to/my/project/node_modules/babel-core/lib/transformation/pipeline.js:47:17)
    at Object.transformFileSync (/path/to/my/project/node_modules/babel-core/lib/api/node.js:152:10)
    at compile (/path/to/my/project/node_modules/babel-register/lib/node.js:118:20)
    at loader (/path/to/my/project/node_modules/babel-register/lib/node.js:144:14)
    at Object.require.extensions.(anonymous function) [as .jsx] (/path/to/my/project/node_modules/babel-register/lib/node.js:154:7)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/path/to/my/project/src/shared/App.jsx:3:1)

@michalkvasnicak
Copy link
Owner Author

@hardchor Yes, I am sorry, I misunderstood how release channels work in npm. I published 1.2.5. Could you try to update if it fixes your problem?

@michalkvasnicak michalkvasnicak merged commit bea58d0 into master Mar 21, 2017
@michalkvasnicak michalkvasnicak deleted the cache-and-circular-deps branch March 21, 2017 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants