Skip to content

Enable loading CSS from external deps #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2017
Merged

Enable loading CSS from external deps #64

merged 2 commits into from
Nov 12, 2017

Conversation

ziad-saab
Copy link
Contributor

This PR enables loading of CSS files from external dependencies. In our monorepo project, we sometimes load CSS from dependencies, like so:

import modularStyles from '@company/brand/styles.css';

Currently, without this fix this results in:

var modularStyles = {};

Because the css file is never being required properly.

@ziad-saab ziad-saab force-pushed the require-actual-file branch from 07fb808 to 01062c9 Compare November 2, 2017 17:08
@ziad-saab
Copy link
Contributor Author

@michalkvasnicak :)

@michalkvasnicak
Copy link
Owner

@ziad-saab Hello, I am sorry it takes me so long, I will take a look on this during the weekend.

@michalkvasnicak michalkvasnicak merged commit 654f4a4 into michalkvasnicak:master Nov 12, 2017
@michalkvasnicak
Copy link
Owner

@ziad-saab thank you, released as 1.2.8.

@ziad-saab
Copy link
Contributor Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ziad-saab @michalkvasnicak