Cleanup stuff for 2.0 version #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| html, body, body div, span, object, iframe, h1, h2, h3, h4, h5, h6, p, blockquote, pre, abbr, address, cite, code, del, dfn, em, img, ins, kbd, q, samp, small, strong, sub, sup, var, b, i, dl, dt, dd, ol, ul, li, fieldset, form, label, legend, table, caption, tbody, tfoot, thead, tr, th, td, article, aside, figure, footer, header, menu, nav, section, time, mark, audio, video, details, summary { | ||
| html, | ||
| body, | ||
| body div, |
d8f50dd to
396b455
Compare
| audio, | ||
| video, | ||
| details, | ||
| summary { |
There was a problem hiding this comment.
This list is pretty exhaustive to me, we don’t use all those elements in our projects and I feel we should add them manually in projects where we use them. Personally, I’d keep:
html,
body,
div,
span,
object,
iframe,
h1,
h2,
h3,
h4,
h5,
h6,
p,
blockquote,
pre,
abbr,
code,
em,
img,
small,
strong,
sub,
sup,
ol,
ul,
li,
fieldset,
form,
label,
legend,
table,
tbody,
tfoot,
thead,
tr,
th,
td,
article,
aside,
footer,
header,
nav,
section,
time,
audio,
videoWhat do you think?
396b455 to
7a9433e
Compare
| button, input, select, textarea {margin: 0;} | ||
| input[type="button"], | ||
| input[type="submit"], | ||
| input[type="file"], |
There was a problem hiding this comment.
Should we add input[type="reset"]?
|
👍 |
7a9433e to
559c527
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You’re probably better off reviewing the whole file.
I basically ended up cleanup up the syntax inconstancies as well as removing useless selectors and properties. Hopefully after this PR we’ll be able to release a 2.0 version that satisfy us all 😀