Skip to content

Clarify Ember configuration steps. #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Clarify Ember configuration steps. #19

wants to merge 1 commit into from

Conversation

lewazo
Copy link
Member

@lewazo lewazo commented Sep 15, 2018

Since Ember 2.15, we do not need to use ember-cli-node-assets in order to import files from node_modules anymore.

Since Ember 2.15, we do not need to use `ember-cli-node-assets` in order to import files from node_modules anymore.
@remi remi requested a review from charlesdemers March 25, 2019 19:00
@charlesdemers
Copy link
Member

@remiprev I think this should be closed, we should explain what the reset does instead of how to use it in specific stacks, what do you think?

@remi
Copy link
Member

remi commented Mar 25, 2019

we should explain what the reset does instead of how to use it in specific stacks

I don’t know, I think it’s kinda cool to show how to use with various frameworks, since the package is framework-agnostic.

A good compromise would be to provide links to documentation URLs (for a list of select frameworks and build tools) that explain how to import a stylesheet from an NPM dependency? That way we wouldn’t have to worry about keeping that documentation up-to-date in our README.md but we’d be still helpful for our users 😄

Would that make sense?

@charlesdemers
Copy link
Member

That would certainly be better but I don't know, I feel a README like the normalize.css one would be the best https://github.com/necolas/normalize.css

Either way, I think this PR should be closed 😄We can change the README in a new PR with the correct description!

@remi
Copy link
Member

remi commented Mar 27, 2019

Let’s close this issue since #21 will address the problem 😄👍

@remi remi closed this Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants