Skip to content

Commit 99e2d84

Browse files
maskaravivekmisaochan
authored andcommitted
Wikidata edit fix (commons-app#1800)
Wikidata edit fix
1 parent 132f56e commit 99e2d84

File tree

4 files changed

+11
-8
lines changed

4 files changed

+11
-8
lines changed

app/src/main/java/fr/free/nrw/commons/nearby/NearbyListFragment.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,12 +148,13 @@ public void onActivityResult(int requestCode, int resultCode, Intent data) {
148148
if (resultCode == RESULT_OK) {
149149
Timber.d("OnActivityResult() parameters: Req code: %d Result code: %d Data: %s",
150150
requestCode, resultCode, data);
151+
String wikidataEntityId = directPrefs.getString("WikiDataEntityId", null);
151152
if (requestCode == ContributionController.SELECT_FROM_CAMERA) {
152153
// If coming from camera, pass null as uri. Because camera photos get saved to a
153154
// fixed directory
154-
controller.handleImagePicked(requestCode, null, true, null);
155+
controller.handleImagePicked(requestCode, null, true, wikidataEntityId);
155156
} else {
156-
controller.handleImagePicked(requestCode, data.getData(), true, null);
157+
controller.handleImagePicked(requestCode, data.getData(), true, wikidataEntityId);
157158
}
158159
} else {
159160
Timber.e("OnActivityResult() parameters: Req code: %d Result code: %d Data: %s",

app/src/main/java/fr/free/nrw/commons/nearby/NearbyMapFragment.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -770,12 +770,13 @@ public void onActivityResult(int requestCode, int resultCode, Intent data) {
770770
if (resultCode == RESULT_OK) {
771771
Timber.d("OnActivityResult() parameters: Req code: %d Result code: %d Data: %s",
772772
requestCode, resultCode, data);
773+
String wikidataEntityId = directPrefs.getString("WikiDataEntityId", null);
773774
if (requestCode == ContributionController.SELECT_FROM_CAMERA) {
774775
// If coming from camera, pass null as uri. Because camera photos get saved to a
775776
// fixed directory
776-
controller.handleImagePicked(requestCode, null, true, null);
777+
controller.handleImagePicked(requestCode, null, true, wikidataEntityId);
777778
} else {
778-
controller.handleImagePicked(requestCode, data.getData(), true, null);
779+
controller.handleImagePicked(requestCode, data.getData(), true, wikidataEntityId);
779780
}
780781
} else {
781782
Timber.e("OnActivityResult() parameters: Req code: %d Result code: %d Data: %s",

app/src/main/java/fr/free/nrw/commons/nearby/PlaceRenderer.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@
3131
import fr.free.nrw.commons.di.ApplicationlessInjection;
3232
import timber.log.Timber;
3333

34+
import static fr.free.nrw.commons.wikidata.WikidataConstants.WIKIDATA_ENTITY_ID_PREF;
35+
3436
public class PlaceRenderer extends Renderer<Place> {
3537

3638
@BindView(R.id.tvName) TextView tvName;
@@ -126,6 +128,7 @@ private void storeSharedPrefs() {
126128
editor.putString("Title", place.getName());
127129
editor.putString("Desc", place.getLongDescription());
128130
editor.putString("Category", place.getCategory());
131+
editor.putString(WIKIDATA_ENTITY_ID_PREF, place.getWikiDataEntityId());
129132
editor.apply();
130133
}
131134

app/src/main/java/fr/free/nrw/commons/upload/UploadController.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,6 @@ public void startUpload(String title, Uri contentProviderUri, Uri mediaUri, Stri
114114
contribution.setTag("mimeType", mimeType);
115115
contribution.setSource(source);
116116

117-
//Calls the next overloaded method
118-
startUpload(contribution, onComplete);
119-
120117
Timber.d("Wikidata entity ID received from Share activity is %s", wikiDataEntityId);
121118
//TODO: Modify this to include coords
122119
Account currentAccount = sessionManager.getCurrentAccount();
@@ -136,7 +133,8 @@ public void startUpload(String title, Uri contentProviderUri, Uri mediaUri, Stri
136133
contribution.setWikiDataEntityId(wikiDataEntityId);
137134
contribution.setContentProviderUri(contentProviderUri);
138135

139-
136+
//Calls the next overloaded method
137+
startUpload(contribution, onComplete);
140138
}
141139

142140
/**

0 commit comments

Comments
 (0)