-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Wikidata edit fix #1800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wikidata edit fix #1800
Conversation
Only one line fix, it will be easier if you do. So I don't create another PR. Then wikidata uploads are linked.
This fix solved everything for me. |
@neslihanturan Thanks for the tip. :) I have added the line that you mentioned. @misaochan Can you help in testing this PR. |
Codecov Report
@@ Coverage Diff @@
## 2.8-release #1800 +/- ##
==============================================
- Coverage 3.66% 3.65% -0.01%
==============================================
Files 188 188
Lines 9478 9483 +5
Branches 839 839
==============================================
Hits 347 347
- Misses 9107 9112 +5
Partials 24 24
Continue to review full report at Codecov.
|
Tested with one image, it works :-) |
I can confirm that uploads from Nearby (both map and list) are both working. |
I have successfully added https://www.wikidata.org/wiki/Q19871703 via Nearby Map, and https://www.wikidata.org/wiki/Q2137835 via Nearby List. :) Great job @maskaravivek and @neslihanturan ! |
Wikidata edit fix
Title (required)
Fixes #1601