IE 8/9 support

[tedliang]

Great project! Exactly what we are after. Thanks for sharing. Any particular reason not supporting IE 8 or 9?

[mistic100]

I don't want to take time to test (need to setup two VM etc).
Feedbacks and pull request are welcome

I'm already sure you will need a shim for Array.indexOf on IE8

[abeverley]

Okay, I'd like to pick up on this. (Unfortunately I have to support IE8 for a company I'm working for).

The initial hurdle is indeed the indexOf function. I consider the cleanest way to fix this is to use underscore.js. Would you be prepared to add such a dependency? I've just done a quick test with IE8, and using underscore.js fixes the actual rendering of the QueryBuilder, but I need to do some further testing to see if other functionality works.

Thanks for a great module,

Andy

[mistic100]

Nope, no unnecessary dependency (I even want to remove Bootstrap) as indexOf is available as a very light shim
https://developer.mozilla.org/fr/docs/Web/JavaScript/Reference/Objets_globaux/Array/indexOf#Compatibility

or simply use https://github.com/es-shims/es5-shim in your project, it's a life savior

[abeverley]

Okay, fair enough. You'd be happy inserting that shim into query-builder.js though?

[abeverley]

If you are, I'll create the patch (along with a couple of others).

[abeverley]

Oh, and just to check: when creating a patch should I only patch the file in the "src" directory, and then you'll update the build in "dist"?

[mistic100]

I not confident with that either. IMHO polyfills should be loaded at project-level, not plugin-level. Array.indexOf is a very common function, if all plugins integrate the polyfill one will get a serious load overhead.

If you use underscore, at polyfill is as simple as

if (!Array.prototype.indexOf) {
    Array.prototype.indexOf = function(value) {
        return _.indexOf(this, value);
    }
}

If you think indexOf is the only requirement for IE8 I'll make it clear on the doc.

[abeverley]

Okay, that's fine.That's the main issue, but there are a couple of other minor things that need changing too - I'll supply patches shortly.

[mistic100]

Thanks :)

About the files you can just patch "src", I'll update everything before the next release

[sukima]

I agree, es5-shim should be loaded at project level. In theory you should say out of box supports IE10+ if you want IE8/9 then also include the es5-shim before you load this project. Easy peasy.

[abeverley]

I haven't forgotten about this, just been distracted with a couple of other things.

I have it working "good enough to use", but need to spend a bit longer on it to create the patches etc. It won't be perfect (the lines don't align properly that join the conditions), but it's at least usable.

[abeverley]

Great - has support now been added for IE8? Sorry for not doing it myself. Thanks.

[mistic100]

no, if nobody do it it will never be supported
IE8 is too old, move on

ps: I am working (professionally) with big industries with old computer infrastructure and everyone uses at least IE9