Skip to content

Adding two new changers for the sql-support plugin#376

Merged
mistic100 merged 1 commit intomistic100:masterfrom
akshaisarma:sql-support-events
Oct 8, 2016
Merged

Adding two new changers for the sql-support plugin#376
mistic100 merged 1 commit intomistic100:masterfrom
akshaisarma:sql-support-events

Conversation

@akshaisarma
Copy link

@akshaisarma akshaisarma commented Oct 7, 2016

Merge request checklist

  • I read the guidelines for contributing
  • I didn't commited files in the dist directory
  • Unit tests are OK
  • If it's a new feature, I added the necessary unit tests
  • If it's a new language, I filled the __locale and __author fields

This is a followup to #361 (comment). As you say, I am keeping our changes in a separate plugin but I'd like two new change events added to the sql-support plugin since I don't want to maintain a custom copy of it for my plugin. My plugin needs these changers to add its functionality when going back and forth from SQL. Do you think you can add these?

I just migrated these directly from my use-case. I realize it isn't symmetrical (one modifies the whole rule when going from SQL and the other modifies only the field part when going to SQL) but I wanted to hear your thoughts first.

@mistic100 mistic100 merged commit 3e7ecae into mistic100:master Oct 8, 2016
@akshaisarma
Copy link
Author

Thanks, @mistic100! Any rough timelines on an official release?

@akshaisarma akshaisarma deleted the sql-support-events branch October 11, 2016 17:13
@mistic100 mistic100 modified the milestone: 2.3.4 Oct 11, 2016
@mistic100
Copy link
Owner

mistic100 commented Oct 13, 2016

⚠️ I will rename the "getSQLRule" event to "sqlToRule"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments