Conversation
mistic100
pushed a commit
that referenced
this pull request
Feb 1, 2017
Owner
|
62f6f44 |
Contributor
Author
|
Thanks for the 'merge'! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #426
This adds an option for
getRules()to skip empty rules.When clicking add rule, getting the rules would be impossible, it will always return an empty object (or an invalid one when using
allow_invalid).All other rules are now validated, the rule that is empty (did not select an filter or operator) will be removed from the result list and no warning will appear.
Merge request checklist
devand I am issuing the PR todev__localeand__authorfieldsI've tried to use QUnit, but it gave me errors out of the box, related to language files. So I'm not able to test a created test. (Not that experienced as well).
In my best attempt, here is the unit test:
Seems like the example is conflicting, not necessary to keep my version so just rebase it with whatever you have.