Skip to content

wrong sql conversion, not_equal should be converted to <> (instead !=)#632

Closed
chstorb wants to merge 1 commit intomistic100:devfrom
chstorb:dev
Closed

wrong sql conversion, not_equal should be converted to <> (instead !=)#632
chstorb wants to merge 1 commit intomistic100:devfrom
chstorb:dev

Conversation

@chstorb
Copy link

@chstorb chstorb commented Jan 23, 2018

Merge request checklist

  • I read the guidelines for contributing
  • I created my branch from dev and I am issuing the PR to dev
  • Unit tests are OK
  • If it's a new feature, I added the necessary unit tests
  • If it's a new language, I filled the __locale and __author fields

@mistic100
Copy link
Owner

mistic100 commented Jan 23, 2018

Why bothering since both are supported by every DBMS ?

And you can configure it at runtime :

$('#builder').queryBuilder({
  sqlOperators: {
    not_equal: { op: '<> ?' }
  }
});

@chstorb
Copy link
Author

chstorb commented Jan 23, 2018

When creating comparison expressions in .NET Framework, the operator != (not ISO standard) isn't allowed.

@mistic100
Copy link
Owner

If I change it I am 100% sure someone will come asking for help because it's system only works with "!=".

I do not say the change is not legitimate, but since you have a simple solution to use "<>" where you need I prefer to not take the risk to break things.

@mistic100 mistic100 closed this Jan 23, 2018
@chstorb
Copy link
Author

chstorb commented Jan 23, 2018

I recommend <> to use because it is ANSI SQL-92 compliant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants