wrong sql conversion, not_equal should be converted to <> (instead !=)#632
Closed
chstorb wants to merge 1 commit intomistic100:devfrom
Closed
wrong sql conversion, not_equal should be converted to <> (instead !=)#632chstorb wants to merge 1 commit intomistic100:devfrom
chstorb wants to merge 1 commit intomistic100:devfrom
Conversation
Owner
|
Why bothering since both are supported by every DBMS ? And you can configure it at runtime : $('#builder').queryBuilder({
sqlOperators: {
not_equal: { op: '<> ?' }
}
}); |
Author
|
When creating comparison expressions in .NET Framework, the operator != (not ISO standard) isn't allowed. |
Owner
|
If I change it I am 100% sure someone will come asking for help because it's system only works with "!=". I do not say the change is not legitimate, but since you have a simple solution to use "<>" where you need I prefer to not take the risk to break things. |
Author
|
I recommend <> to use because it is ANSI SQL-92 compliant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge request checklist
devand I am issuing the PR todev__localeand__authorfields