Skip to content

Dev-bootstrap-5#988

Closed
dethell wants to merge 8 commits intomistic100:devfrom
dethell:dev-bootstrap-5
Closed

Dev-bootstrap-5#988
dethell wants to merge 8 commits intomistic100:devfrom
dethell:dev-bootstrap-5

Conversation

@dethell
Copy link

@dethell dethell commented Jan 9, 2024

Merge request checklist

  • I read the guidelines for contributing
  • I created my branch from dev and I am issuing the PR to dev
  • I didn't pushed the dist directory
  • If it's a new feature, I added the necessary unit tests
  • If it's a new language, I filled the __locale and __author fields

stephencmorton and others added 7 commits September 2, 2023 20:23
Something to do with the way JS packages are installed.
I'm not sure if it's the right solution or not, but the error goes away
if I do this.

-  } else if (typeof exports === 'object') {
+  } else if (typeof module === 'object') {
     // Node, CommonJS-like
     module.exports = factory(require('jquery'));
@dethell dethell mentioned this pull request Jan 9, 2024
4 tasks
@liamkeily liamkeily mentioned this pull request Jan 17, 2024
5 tasks
@liamkeily
Copy link
Collaborator

Continued at #992

@dethell
Copy link
Author

dethell commented Jan 17, 2024

Closing in favor of #992

@dethell dethell closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants