Skip to content

Fix Development Errors#989

Merged
mistic100 merged 2 commits intomistic100:devfrom
liamkeily:dev
Jan 16, 2024
Merged

Fix Development Errors#989
mistic100 merged 2 commits intomistic100:devfrom
liamkeily:dev

Conversation

@liamkeily
Copy link
Collaborator

@liamkeily liamkeily commented Jan 16, 2024

Description

When checking out this project locally I noticed a couple of broken things which I have fixed in this PR.

Merge request checklist

  • I read the guidelines for contributing
  • I created my branch from dev and I am issuing the PR to dev
  • I didn't pushed the dist directory
  • If it's a new feature, I added the necessary unit tests
  • If it's a new language, I filled the __locale and __author fields

Before

image

After

image

<div class="page-header">
<a class="pull-right" href="https://github.com/mistic100/jQuery-QueryBuilder">
<img src="https://github.githubassets.com/images/modules/logos_page/Octocat.png" height=48px>
<img src="https://github.githubassets.com/assets/GitHub-Mark-ea2971cee799.png" style="height:48px;">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image no longer exists so I have replaced with another image

Comment on lines -662 to -665

<script>
document.write('<script src="//' + location.host.split(':')[0] + ':35729/livereload.js" async defer><' + '/script>');
</script>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This snippet appears to come from the live-server docs, but the project appears to be using alive-server which works differently

You don't need to install any browser plugins or manually add code snippets to your pages for the reload functionality to work

@liamkeily liamkeily changed the title Resolve Console Errors Resolve Development Errors Jan 16, 2024
@liamkeily liamkeily changed the title Resolve Development Errors Fix Development Errors Jan 16, 2024
@mistic100 mistic100 merged commit b377be6 into mistic100:dev Jan 16, 2024
liamkeily added a commit to liamkeily/jQuery-QueryBuilder that referenced this pull request Jan 16, 2024
* Fix Development Errors (mistic100#989)

* Fix Logo Path

* Remove Outdated Live Reload Script

* Replace Glyphicons with Bootstrap Icons

* checkbox changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants