Replace Glyphicons with Bootstrap Icons#990
Closed
liamkeily wants to merge 4 commits intomistic100:devfrom
Closed
Conversation
Owner
|
I don't see the point, the BT5 support won't be merged/released until you declare the merge request ready. No point in releasing only the icons. |
Collaborator
Author
|
Glyphicons is no longer supported by Bootstrap 5 but Bootstrap Icons appears to work regardless of Bootstrap version.
I thought breaking this part out would help to reduce the diff of the Bootstrap 5 related stuff to help with reviewing / testing / fixing the remaining issues. |
Collaborator
Author
|
Carried this on here #992 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help with the Bootstrap 5 upgrade #973 I have taken the icon related changes from the other branch and fixed some of the issues. This seems like something we could potentially merge first to help remove distractions from the other PR.
Merge request checklist
devand I am issuing the PR todevdistdirectory__localeand__authorfieldsBefore
After