This repository was archived by the owner on Feb 11, 2022. It is now read-only.
Fix entry about "security_groups" in Readme.md#489
Open
bhagerty wants to merge 1 commit intomitchellh:masterfrom
bhagerty:patch-1
Open
Fix entry about "security_groups" in Readme.md#489bhagerty wants to merge 1 commit intomitchellh:masterfrom bhagerty:patch-1
bhagerty wants to merge 1 commit intomitchellh:masterfrom
bhagerty:patch-1
Conversation
The entry on security groups, as written, does not fully make sense because it contrasts "VPC" and "nondefault VPC." But a "nodefault VPC" is still a "VPC"; in other words, the two categories actually overlap. The text should refer to a "default VPC" versus a "nondefault VPC"—categories that are mutually exclusive and exhaustive. While this may seem trivial, it confused me when I was trying to figure out whether to use Group Name or Group ID in my Vagrantfile. I have made some other minor changes that I think make the language even clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entry on security groups, as written, does not fully make sense because it contrasts "VPC" and "nondefault VPC." But a "nondefault VPC" is still a "VPC"; in other words, the two categories (VPC and nondefault VPC) actually overlap. The text should refer to a "default VPC" versus a "nondefault VPC"—categories that are mutually exclusive and exhaustive.
While this may seem trivial, it confused me when I was trying to figure out whether to use Group Name or Group ID in my Vagrantfile. I have made some other minor changes that I think make the language even clearer.