Updated intervalHandler to support continuous run#1
Merged
Conversation
intervalHandler is updated in order to support continuous timer run, even after duration is completed
Flag for single call to callback when timer completes in continuous run.
1. Added stopTimerOnDuration in config to run timer continuously. 2. Updated intervalHandler to support continuous run 3. Added Flag isCallbackCalled to stop multiple calls to callback after reaching the duration in continuous run.
mohitYogi
added a commit
that referenced
this pull request
Dec 5, 2020
* Updated timer to support continuous run (#1) (walmik#92) * Updated timer to support continuous run (#1) * Updated intervalHandler to support continuous run intervalHandler is updated in order to support continuous timer run, even after duration is completed * Flag for single call to callback Flag for single call to callback when timer completes in continuous run. * Update utils.js * support continuous Timer run 1. Added stopTimerOnDuration in config to run timer continuously. 2. Updated intervalHandler to support continuous run 3. Added Flag isCallbackCalled to stop multiple calls to callback after reaching the duration in continuous run. * Updates after review. 1. Removed stopTimerOnDuration flag (repeat flag do the same.) 2. Removed isCallbackCalled flag, as suggested after commit review. * Update after Review Removed flag isCallbackCalled. (Not required). * Updates after review 1. Removed stopTimerOnDuration flag (repeat flag do the same.) 2. Removed isCallbackCalled flag, as suggested after commit review. * Updates after Review 1. Removed stopTimerOnDuration flag (repeat flag do the same.) 2. Removed isCallbackCalled flag, as suggested after commit review. * Patch version New rule for checking timer duration completed. * Update timer.jquery.js * Semicolon & Comment update Added missing semi colon. Updated Comment. * Removed & Updated Comment * Update README.md (walmik#99) Let's not send people to an ad-infested abandoned domain name :) Co-authored-by: Alan <my@working.name>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
intervalHandler is updated in order to support continuous timer run, even after duration is completed