This repository was archived by the owner on May 14, 2024. It is now read-only.
Allow scrollable viewports different from window#8
Open
elhoyos wants to merge 4 commits intomorr:masterfrom
Open
Allow scrollable viewports different from window#8elhoyos wants to merge 4 commits intomorr:masterfrom
elhoyos wants to merge 4 commits intomorr:masterfrom
Conversation
Conflicts: jquery.appear.js
Owner
|
@elhoyos Can't merge it automatically with github. Could you please fix conflicts? $(window).offset() returns undefined so viewport_offset.left raises "Cannot read property 'left' of undefined" exception. |
|
This would be a very nice addition, any plans on integrating it? |
Contributor
Author
|
I have been a bit busy these days. Will give it some time this weekend. |
|
👍 seems like this would really complete this plugin |
Contributor
Author
|
Notice these changes provide basic support for viewports. On my side this is enough. You may find some undesirable behavior depending on your needs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.