Skip to content

Conversation

@mrcgrtz
Copy link
Owner

@mrcgrtz mrcgrtz commented Sep 30, 2025

No description provided.

@mrcgrtz mrcgrtz self-assigned this Sep 30, 2025
@coveralls
Copy link

coveralls commented Sep 30, 2025

Pull Request Test Coverage Report for Build 21253082253

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 97.368%

Totals Coverage Status
Change from base Build 21249691871: 0.04%
Covered Lines: 62
Relevant Lines: 64

💛 - Coveralls

@mrcgrtz mrcgrtz requested a review from Copilot September 30, 2025 18:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds compatibility for jQuery 4.0.0-rc.1 by updating the plugin to work with both jQuery 3.x and 4.x versions. The changes ensure the plugin remains compatible with existing jQuery versions while supporting the new release candidate.

  • Updated dependency versions to include jQuery 4.0.0-rc.1
  • Fixed a potential jQuery compatibility issue in the plugin code by using $.extend with proper object merging
  • Enhanced CI/CD pipeline with jQuery version compatibility testing

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
package.json Updated jQuery dependency to 4.0.0-rc.1 and added jQuery 4.x to peer dependencies
jquery.externalize.js Fixed jQuery compatibility issue with $.extend and optimized DOM property access
README.md Updated documentation examples to reference jQuery 4.0.0
.github/workflows/test.yml Enhanced CI with jQuery compatibility matrix testing and workflow improvements

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mrcgrtz mrcgrtz force-pushed the feature/jquery-4 branch 2 times, most recently from 50904e6 to d52651e Compare October 3, 2025 18:52
@mrcgrtz mrcgrtz marked this pull request as draft December 7, 2025 23:56
@mrcgrtz mrcgrtz marked this pull request as ready for review January 22, 2026 14:48
@mrcgrtz mrcgrtz requested a review from Copilot January 22, 2026 14:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mrcgrtz mrcgrtz merged commit 51031f6 into main Jan 22, 2026
6 checks passed
@mrcgrtz mrcgrtz deleted the feature/jquery-4 branch January 22, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants