ProviderContract.Filter > shared filter params#42
Conversation
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a new Secret data class in Kotlin to wrap sensitive data and mask it in toString() outputs. The review feedback suggests improving the class by implementing java.io.Serializable to prevent serialization errors and declaring the type parameter as covariant (out T) for greater flexibility.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Code Review
This pull request introduces a new Secret wrapper class designed to mask sensitive data in its toString() representation. The feedback suggests having Secret implement java.io.Serializable to prevent potential NotSerializableException runtime errors when used within other serializable classes.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
This PR introduces a small model wrapper intended to prevent accidental leakage of sensitive values via toString() output.
Changes:
- Added
org.mtransit.commons.model.Secret<T>with a redactedtoString()implementation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- commons-android: `ProviderContract.Filter` > shared filter params mtransitapps/commons-android#164 - commons-java: `ProviderContract.Filter` > shared filter params mtransitapps/commons-java#42
- commons-android: `ProviderContract.Filter` > shared filter params mtransitapps/commons-android#164 - commons-java: `ProviderContract.Filter` > shared filter params mtransitapps/commons-java#42
- commons-android: `ProviderContract.Filter` > shared filter params mtransitapps/commons-android#164 - commons-java: `ProviderContract.Filter` > shared filter params mtransitapps/commons-java#42
- commons-android: `ProviderContract.Filter` > shared filter params mtransitapps/commons-android#164 - commons-java: `ProviderContract.Filter` > shared filter params mtransitapps/commons-java#42
- commons-android: `ProviderContract.Filter` > shared filter params mtransitapps/commons-android#164 - commons-java: `ProviderContract.Filter` > shared filter params mtransitapps/commons-java#42
No description provided.