Skip to content

ProviderContract.Filter > shared filter params#42

Merged
mmathieum merged 2 commits into
masterfrom
mm/shared_filter_params
Jun 26, 2026
Merged

ProviderContract.Filter > shared filter params#42
mmathieum merged 2 commits into
masterfrom
mm/shared_filter_params

Conversation

@mmathieum

Copy link
Copy Markdown
Member

No description provided.

@mmathieum mmathieum self-assigned this Jun 26, 2026
@mmathieum

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Secret data class in Kotlin to wrap sensitive data and mask it in toString() outputs. The review feedback suggests improving the class by implementing java.io.Serializable to prevent serialization errors and declaring the type parameter as covariant (out T) for greater flexibility.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/main/java/org/mtransit/commons/model/Secret.kt Outdated
@mmathieum mmathieum marked this pull request as ready for review June 26, 2026 17:47

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Secret wrapper class designed to mask sensitive data in its toString() representation. The feedback suggests having Secret implement java.io.Serializable to prevent potential NotSerializableException runtime errors when used within other serializable classes.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/main/java/org/mtransit/commons/model/Secret.kt

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a small model wrapper intended to prevent accidental leakage of sensitive values via toString() output.

Changes:

  • Added org.mtransit.commons.model.Secret<T> with a redacted toString() implementation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/main/java/org/mtransit/commons/model/Secret.kt
Comment thread src/main/java/org/mtransit/commons/model/Secret.kt
@mmathieum mmathieum merged commit 7ce3a46 into master Jun 26, 2026
8 of 9 checks passed
@mmathieum mmathieum deleted the mm/shared_filter_params branch June 26, 2026 18:52
montransit added a commit to mtransitapps/mtransit-for-android that referenced this pull request Jun 26, 2026
- commons-android: `ProviderContract.Filter` > shared filter params mtransitapps/commons-android#164
- commons-java: `ProviderContract.Filter` > shared filter params mtransitapps/commons-java#42
montransit added a commit to mtransitapps/ca-st-hyacinthe-transport-collectif-bus-android that referenced this pull request Jun 27, 2026
- commons-android: `ProviderContract.Filter` > shared filter params mtransitapps/commons-android#164
- commons-java: `ProviderContract.Filter` > shared filter params mtransitapps/commons-java#42
montransit added a commit to mtransitapps/ca-mrc-nicolet-yamaska-bili-bus-android that referenced this pull request Jun 27, 2026
- commons-android: `ProviderContract.Filter` > shared filter params mtransitapps/commons-android#164
- commons-java: `ProviderContract.Filter` > shared filter params mtransitapps/commons-java#42
montransit added a commit to mtransitapps/ca-ottawa-oc-transpo-bus-android that referenced this pull request Jun 28, 2026
- commons-android: `ProviderContract.Filter` > shared filter params mtransitapps/commons-android#164
- commons-java: `ProviderContract.Filter` > shared filter params mtransitapps/commons-java#42
montransit added a commit to mtransitapps/ca-ottawa-oc-transpo-train-android that referenced this pull request Jun 28, 2026
- commons-android: `ProviderContract.Filter` > shared filter params mtransitapps/commons-android#164
- commons-java: `ProviderContract.Filter` > shared filter params mtransitapps/commons-java#42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants