Skip to content

Add exception to prevent invalid configuration #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

michael-misshore
Copy link
Contributor

manifest and css path(s) cannot/should not be both defined.

Addresses #45

manifest and css path(s) cannot/should not be both defined
@michael-misshore michael-misshore merged commit 51bb069 into master Aug 19, 2019
@michael-misshore michael-misshore deleted the add-manifest-path-exception branch August 19, 2019 22:03
@keferboeck
Copy link

Doesn't solve the issue - just tried with this specific commit : ( - but still getting this:

Error: ENOENT: no such file or directory, open '/assets/application-fe612b1419b5a8d61dfc3dbc0fe5e5e58683baab1701e8e5870e475209314419.css'
Failed to get CSS for route /
  with options={"url"=>"http://localhost:3000/", "css"=>"/assets/application-fe612b1419b5a8d61dfc3dbc0fe5e5e58683baab1701e8e5870e475209314419.css", "width"=>1300, "height"=>900, "timeout"=>30000, "forceInclude"=>[], "strict"=>false, "maxEmbeddedBase64Length"=>1000, "userAgent"=>"Penthouse Critical Path CSS Generator", "renderWaitTime"=>100, "blockJSRequests"=>true, "customPageHeaders"=>{"Accept-Encoding"=>"identity"}}

@kevinhq
Copy link

kevinhq commented Nov 12, 2019

Doesn't solve the issue - just tried with this specific commit : ( - but still getting this:

Error: ENOENT: no such file or directory, open '/assets/application-fe612b1419b5a8d61dfc3dbc0fe5e5e58683baab1701e8e5870e475209314419.css'
Failed to get CSS for route /
  with options={"url"=>"http://localhost:3000/", "css"=>"/assets/application-fe612b1419b5a8d61dfc3dbc0fe5e5e58683baab1701e8e5870e475209314419.css", "width"=>1300, "height"=>900, "timeout"=>30000, "forceInclude"=>[], "strict"=>false, "maxEmbeddedBase64Length"=>1000, "userAgent"=>"Penthouse Critical Path CSS Generator", "renderWaitTime"=>100, "blockJSRequests"=>true, "customPageHeaders"=>{"Accept-Encoding"=>"identity"}}

Same here. This is merged to 4.0.1, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants