Return first css path when route index is nil #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using
CriticalPathCss.generate
to generate dynamic routes that aren't defined incritical_path_css.yml
, and hit with this errorTypeError: no implicit conversion from nil to integer
.The reason is because
routes.index(route)
isnil
, and you cannot call[nil]
in an array, hencecss_paths.first
is never called. Let me know if.to_i
works, since it might seems too magical for some people. On the other hand, please let me know if I'm using the.generate
method incorrectly...