Fix notification bug commons-app#4547 (commons-app#4570)

madhurgupta10 · web-flow · commit cba99ae5e3ca · 2021-08-24T02:38:28.000+10:00
diff --git a/app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt b/app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt
@@ -301,13 +301,13 @@ class UploadWorker(var appContext: Context, workerParams: WorkerParameters) :
                                     "WikiDataEdit not required, upload success"
                                 )
                                 saveCompletedContribution(contribution,uploadResult)
-                                showSuccessNotification(contribution)
                             }else{
                                 Timber.d(
                                     "WikiDataEdit not required, making wikidata edit"
                                 )
                                 makeWikiDataEdit(uploadResult, contribution)
                             }
+                            showSuccessNotification(contribution)
 
                         } else {
                             Timber.e("Stash Upload failed")

Original file line number	Diff line number	Diff line change
`@@ -301,13 +301,13 @@ class UploadWorker(var appContext: Context, workerParams: WorkerParameters) :`
`301`	`301`	`"WikiDataEdit not required, upload success"`
`302`	`302`	`)`
`303`	`303`	`saveCompletedContribution(contribution,uploadResult)`
`304`		`- showSuccessNotification(contribution)`
`305`	`304`	`}else{`
`306`	`305`	`Timber.d(`
`307`	`306`	`"WikiDataEdit not required, making wikidata edit"`
`308`	`307`	`)`
`309`	`308`	`makeWikiDataEdit(uploadResult, contribution)`
`310`	`309`	`}`
	`310`	`+ showSuccessNotification(contribution)`
`311`	`311`
`312`	`312`	`} else {`
`313`	`313`	`Timber.e("Stash Upload failed")`