Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0f2a5bf9a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| function globToRegex(glob) { | ||
| let out = String(glob) | ||
| .replace(/[.+^${}()|[\]\]/g, '\\$&') |
There was a problem hiding this comment.
The globToRegex helper currently contains an invalid JavaScript regex (/[.+^${}()|[\]\]/g), which causes a SyntaxError when actions/github-script evaluates the step, so this workflow job fails before it can evaluate file changes or enable auto-merge for any PR.
Useful? React with 👍 / 👎.
| .replace(/\*\*/g, '.*') | ||
| .replace(/\*/g, '[^/]*') |
There was a problem hiding this comment.
The replacement order in globToRegex converts ** to .* and then immediately rewrites that * into [^/]*, so patterns like **/.github/workflows/** and **/*.sql no longer match repo-root paths (for example .github/workflows/x.yml or schema.sql), allowing denylisted files to bypass the safety gate and be auto-merged when labeled.
Useful? React with 👍 / 👎.
Codex Workflow Rollout
This PR adds the safe Codex auto-merge workflow for this repository.
Verification
..github/workflows/codex-automerge.ymldocs/codex-workflow.md**/*wrangler*.{json,toml}**/.github/workflows/****/src/**/stripe***/src/**/payments***/src/**/auth***/src/**/sessions***/src/**/worker/**/env***/routing/****/redirect**/canonical**/migrations/****/*.sqlPR behavior notes
docs/codex-workflow.md.automerge, non-draft PRs, andchatgpt-codex-connectorauthor orcodex/head branch.Label guidance (manual)
Do NOT label this PR as
automerge; rollout PRs are for infrastructure updates only.