101 Add hot reload to storybook #188
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a CircleCI config file based on the same config I use for my own website. It makes it easy to have multiple steps running in parallel, such as running tests and coverage reports.
Forcing contributors to use Commitizen to format their commit messages will make our lives much simpler, especially once we've added `semantic-release`.
Add `semantic-release` to the repo and the build pipeline. This will handle automatically publishing to npm based on commit messages. #13
The Roll For Guild Node container doesn't include `git`, which is required by semantic-release. #13
I got a bunch of permission errors last time I tried to build in ~/app. I'm pretty sure building in the default directory should work just as well.
I've removed containers from tthe config entirely because I don't think we need them. Hopefully this will fix the build. 🤷🏻♂️
Switching back to container because I have no idea how to fix the errors that came up without them. Additionally, I'm changing the working directory to `~/tmp` to see if that works better than the `~/app` folder.
I think the issue was that the app was being built into the root user's home directory rather than the `circleci` user's home directory. 🤞
I finally figured it out. Restoring the cache was trying to restore the cache from an older build that used a different image in which the root user was the one doing all the tasks. I'm pushing a build that doesn't restore the cache, then I'll add those steps back in after the next build.
By removing strict host key checking for Github, we shouldn't run into the issue where host authenticity verification stalls the deployment.
Repository cloning in the deploy step was 100% unnecessary.
Add `commitlint` to enforce proper formatting for all commit messages #13
Fix config files
feat(breaking): remove google font import
feat(button): add disabled state button
Since we don't have any tests yet, we want to make sure the build runs successfully on all branches. That way we can at least verify that the build works correctly. closes #13
feat(icons): add kirby icon
fix(style.css): fix margin and padding of body
This removes `semantic-commitlint` from both the local build pipeline and the CI build pipeline. The original value of `semantic-commitlint` was that it would handle linting only the relevant commits, i.e. the commit range under review for a PR. However, the library doesn't seem to respect our altered `commitlint` rules, so we'll be switching to an alternate strategy to handle linting of specific ranges. #13
I've added `circleci-commitlint-step` because it *should* handle linting of the appropriate commitlint ranges via a specialized Docker container for CircleCI with a commit range. #13
refactor: box shadow color
feat: add favicon.ico
Fix `develop` builds
I've added hot reloading to Storybook. This means that during development, all we have to do is run Storybook. As we make changes to the SCSS files, the changes will automatically be reflected in Storybook. 😁
This adds all files in the repo that aren't essential to the operation of the package to the `.npmignore`. This will ensure that things like the `.storybook` directory don't get downloaded everytime somebody adds NES.css to their project.
Slim down our npm package
Member
|
Hey @Digital-Security-Brokerage we already have storybook hot reloading, Our main branch is develop and not master which might have tricked you into thinking we don't have hot reloading. Thanks for the PR anyways. 🙇🏻♂️ We'd like to see more PRs from you 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.