Skip to content

feat(icon): Add about.me icon #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat(icon): Add about.me icon #417

wants to merge 3 commits into from

Conversation

@candywater
Copy link

@candywater candywater commented May 1, 2020

Description
This is a icon about https://about.me

Icon idea is from https://about.me/favicon.ico
It only shows "me" as tab icon in firefox.
Annotation 2020-05-02 021104

Compatibility
It seems fine with compatibility.

Caveats
important: after merging, update document, please.
I should also add this icon to update the document, but i did not add it.
Because I found that document use the following css file, if I add icon to document, it would break document.
https://unpkg.com/nes.css@latest/css/nes.min.css

@candywater candywater changed the title Add about.me icon feat(icon): Add about.me icon May 1, 2020
@guastallaigor guastallaigor requested a review from a team May 1, 2020 20:00
@guastallaigor guastallaigor added the enhancement New feature or request label May 1, 2020
@candywater
feat(icon): add about.me icon
13b1452 
icon  idea is from https://about.me/favicon.ico
it only shows "me" as tab icon in firefox.

ps:意外と地味な作業だった。
@candywater
Copy link
Author

candywater commented May 5, 2020 •
edited
Loading

sorry for again and again force push.... only to change commit message to fit commitlint.
I have changed commit message for several times, but it still cannot pass commitlint test....
But it seems work fine in my local environment.
This is my first time to use commitlint, I cannot figure out how to solve it.

2020-05-05 23_11_44-Window
2020-05-05 23_09_10-Window

I read #413 and #415, understood situation.....

@trezy
Copy link
Member

trezy commented May 5, 2020

Don’t worry @candywater, this is actually an issue with our CI, not your PR. We’re investigating the issue in #415.

@virtuoushub virtuoushub mentioned this pull request May 30, 2020
Closed
@guastallaigor guastallaigor added the waiting - reviewer Waiting for the reviewer to address some situations label Jun 1, 2020
@guastallaigor
Copy link
Member

guastallaigor commented Jun 1, 2020 •
edited
Loading

As much as I would like this icon, I don't have authorization to merge any new icons.
References:

So we will need to wait for the creator in this one.
I will make a new PR to all README.md regarding this.
I do apologize for the delay.

@candywater
Copy link
Author

candywater commented Jun 3, 2020 •
edited
Loading

Thanks for your mention! @guastallaigor
I have read #310 , too.
I understood the situation, maybe NES-icons.css is a much better idea.
and here are the images
image

@trezy trezy added the new icon Adds a new icon label Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@syedabdullahali syedabdullahali syedabdullahali approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@candywater candywater

Labels

enhancement New feature or request new icon Adds a new icon waiting - reviewer Waiting for the reviewer to address some situations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@candywater @trezy @guastallaigor @syedabdullahali