Re-work CSS parsing logic. - #18
Conversation
jgerigmeyer
commented
Aug 22, 2022
jgerigmeyer
left a comment
There was a problem hiding this comment.
@sanajaved7 @oluoluoxenfree I have a number of questions, and it may make sense to talk through them together on a call -- perhaps tomorrow after check-in?
| const { anchorName, anchorEdge, fallbackValue } = parseAnchorFn(node); | ||
| anchorFunctions.push({ | ||
| floatingEl: rule.value, | ||
| floatingEdge: this.declaration.property, |
There was a problem hiding this comment.
We should check whether this is position-related -- if not, then we need a regular math polyfill for it (instead of positioning).
|
Putting this on hold for now, while we reconsider our approach to parsing stylesheets (see: https://oddbird.slack.com/archives/C03K136KX2A/p1661273459265879). |
* main: chore(deps): Automated dependency upgrades (#20)
|
@jgerigmeyer what's most helpful for me to understand or review here? Is a functional review helpful, or is there something I should be digging into code-wise? |
@mirisuzanne There's not a lot functional to review yet (other than looking at what's logged to the console, and comparing that with the demo stylesheets). You could skim the code (mostly the changes in |
|
@sanajaved7 @mirisuzanne I think this is ready for review, then merge into #19? |