First attempt transforming directly to pixel values. - #22
Merged
Conversation
jgerigmeyer
marked this pull request as ready for review
September 7, 2022 18:38
jgerigmeyer
commented
Sep 7, 2022
jgerigmeyer
requested review from
mirisuzanne,
oluoluoxenfree and
sanajaved7
September 7, 2022 20:25
* transform-for-floating-ui: Add Netlify deploy commands
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Member
Author
mirisuzanne
approved these changes
Sep 8, 2022
mirisuzanne
left a comment
Member
There was a problem hiding this comment.
this looks good, with caveats about writing mode (which I think is a separate story?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to resolve
anchor()fns directly to a pixel value, without reference to the floating-el property being declared. Ideally this will allow us to handle math/custom-css-var use-cases (e.g.--center: anchor(--my-anchor 50%);),anchor-size, etc.See: