Use relative paths for emitted files #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegstepura
added a commit
that referenced
this pull request
Jul 3, 2017
|
Merged and released |
|
Just seen this now. Thanks! |
tgroutars
pushed a commit
to producthunt/typed-css-modules-loader
that referenced
this pull request
May 2, 2019
Allow to silence logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
typed-css-modules-loaderemits absolute file paths for all the virtual emitted webpack files, such as the following:/Users/tim/projects/foo/styles/index.css.d.tsAs well as leaking information about the host system into the generated source maps, this also means that the bundled webpack artifact (and therefore its hash etc) will vary according to which user ran the build process.
This PR ensures that emitted file paths are all generated relative to the current webpack context root, such as the following:
styles/index.css.d.ts