Fix for noEmit #22
Merged
Fix for noEmit #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegstepura
reviewed
Aug 20, 2018
index.js
Outdated
| delete options.noEmit; | ||
|
|
||
| // Make sure to not modify options object directly | ||
| var creatorOptions = JSON.parse(JSON.stringify(options)); |
Owner
There was a problem hiding this comment.
Cannot we use Object.assign here?
Contributor
Author
There was a problem hiding this comment.
You're right, no need for deep copy, fixed.
Owner
|
Merged and released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
noEmitoption is being deleted from theoptionsobject.This causes troubles if webpack is processing multiple files as it does not recreate the
optionsand just reuses it so first file would not emit changes but subsequent would.I've also made change to readme, where I updated the syntax for preloaders for new webpack.