converters / datetime - fix object check#7
Merged
AdSchellevis merged 1 commit intoopnsense:masterfrom Apr 17, 2024
Merged
Conversation
Object.is() checks equality between two parameters, not whether the variable is an object, better to use the built-in moment method for this.
AdSchellevis
added a commit
that referenced
this pull request
Apr 17, 2024
AdSchellevis
added a commit
to opnsense/core
that referenced
this pull request
Apr 17, 2024
fichtner
pushed a commit
to opnsense/core
that referenced
this pull request
Apr 22, 2024
(cherry picked from commit 08ee9c0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Object.is() checks equality between two parameters, not whether the variable is an object, better to use the built-in moment method for this.