How to handle invalid CSS values

[vladinator1000]

HI folks, should lightningcss throw an error when you pass it invalid CSS like this one?

.corrupt {
  color: hsla(120, 62.32%;
}

I was hoping this to throw so that I can use lightningcss to validate a dynamic CSS input at runtime.

Playground

For example, when browsers encounter this they error:

[vladinator1000]

Hi @devongovett, I started working on a fix for this. Managed to create a test case for it here #449

Do you have any recommendations on how I could approach the implementation? I'm new to the codebase ❤️

[vladinator1000]

This issue also looks related #398 (comment). I wonder if we should treat this as a parser error or at least print warnings so that people don't need to rely on other linting tools. Pairing non-native tools like that with lightning feels like going 2 steps forward, one step back performance-wise.

I guess the question here is, do we want to support linting?

[devongovett]

Thanks. I think there's a specific error code that we need to handle when parsing custom properties (here). Certain token types are considered errors including CloseParenthesis, CloseSquareBracket, etc. (see here). So I think we'd just want to error whenever we see one of those token types.