Add custom serialize_string function producing shorter representation #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide custom implementation of the serilaize_string function found in cssparser which takes more care to use shortest possible string representation. This is done with through two changes. Firstly, the function figures out whether double or single quotes are better. For example, `Holmes never said "Elementary, my dear Watson."` is best quoted using apostrophes to avoid escaping the double quotes inside. Secondly, the function avoids unnecessary space after hex encoding of control characters. For example, `\x01Z` is escaped as `"\1Z"` rather than `"\1 Z"`. To make this all more consistent throughout the code-base, introduce serialize module with symbols corresponding to serialise_* functions in cssparse crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide custom implementation of the serilaize_string function found in cssparser which takes more care to use shortest possible string representation. This is done with through two changes.
Firstly, the function figures out whether double or single quotes are better. For example,
Holmes never said "Elementary, my dear Watson."is best quoted using apostrophes to avoid escaping the double quotes inside.Secondly, the function avoids unnecessary space after hex encoding of control characters. For example,
\x01Zis escaped as"\1Z"rather than"\1 Z".To make this all more consistent throughout the code-base, introduce serialize module with symbols corresponding to serialise_* functions in cssparse crate.