fix(color-scheme): for unknown keywords, output them as-is instead of normal#1152
Merged
devongovett merged 1 commit intoparcel-bundler:masterfrom Feb 18, 2026
Merged
Conversation
… `normal` - Rework `ColorScheme::parse` to consume only known keywords (`normal`, `only`, `light`, `dark`) instead of swallowing unknown idents. This lets `Property::parse` fail `expect_exhausted` and fall back to `Property::Unparsed`, so values like `inherit`, `unset`, and unknown identifiers are kept and serialized as-is rather than being normalized to `normal`. - Also fix `ColorScheme::to_css` to serialize `only` without a leading space when it appears alone.
devongovett
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ColorScheme::parseto consume only known keywords (normal,only,light,dark) instead of swallowing unknown idents. This letsProperty::parsefailexpect_exhaustedand fall back toProperty::Unparsed, so values likeinherit,unset, and unknown identifiers are kept and serialized as-is rather than being normalized tonormal.ColorScheme::to_cssto serializeonlywithout a leading space when it appears alone.Part of: #821 (comment)