Allow visitors to add dependencies#1170
Merged
devongovett merged 2 commits intomasterfrom Mar 5, 2026
Merged
Conversation
sapphi-red
approved these changes
Mar 4, 2026
Contributor
sapphi-red
left a comment
There was a problem hiding this comment.
Thank you! I've tested this PR at vitejs/vite#21748 and it worked for my use case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #877
Visitors can now be functions that receive an
addDependencyfunction. When called, this adds either a file or glob dependency that is returned to the caller (e.g. a bundler). Lightning CSS doesn't do anything with these dependencies by default: the caller is responsible for implementing file watching or cache invalidation based on these dependencies.composeVisitorsalso has support for visitors that are functions, passing the options to each visitor.This is implemented entirely in the JavaScript layer. Dependencies do not cross the Rust boundary. They are appended to the list of other dependencies such as imports and urls returned by Rust when
analyzeDependenciesis true.