Merged
Conversation
Member
Author
|
Did some testing and verified the output seems reasonable. There are certainly improvements we can make (e.g. a nicer format for vendor prefixes in properties, more detailed serialization of selector components, etc.), but it seems usable for now. To use, you need to enable the cargo run --example serialize --features serde test.css | jlessThe format follows the documented rust structs, but with kebab case for enum variants (matching CSS itself), and a few other minor differences. Not sure if possible, but a future improvement could be to somehow generate TypeScript definitions for the format. Going to merge as MVP. Please let me know if you have feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #143
This adds serde serialization and deserialization support to all AST nodes, behind a feature flag. Appears to work, but need to verify the output.
cc. @lucacasonato @johno