CLI: Return code and CSS modules as JSON when output file is not given#192
Merged
devongovett merged 1 commit intoparcel-bundler:masterfrom Jun 11, 2022
Merged
Conversation
devongovett
approved these changes
Jun 7, 2022
Member
devongovett
left a comment
There was a problem hiding this comment.
Technically, this is a breaking change but I think we can get away with it.
Member
|
We should probably update the tests for this. |
Member
|
FYI added tests for this and your other PR in a5fdcc1. Also renamed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My very first rust experience, so be gentle ;)
I wanted a way to get both the resulting code and the CSS modules from the CLI without having to specify an output file, which means I would have to read files to get what I want.
So in this PR, if
output-fileflag is not given, andcss-modulesflag is given, the CLI will return a JSON string containing the code and the CSS modules...{ "code": ".cLD2Uq_header {\n background-color: #00f;\n}\n", "modules": { "header": { "composes": [], "isReferenced": false, "name": "cLD2Uq_header" } } }All other functionality is maintained.
Would appreciate any feedback. thx