fix: Missing semicolon in Custom Media Queries#260
Merged
devongovett merged 3 commits intoparcel-bundler:masterfrom Aug 25, 2022
Merged
fix: Missing semicolon in Custom Media Queries#260devongovett merged 3 commits intoparcel-bundler:masterfrom
devongovett merged 3 commits intoparcel-bundler:masterfrom
Conversation
devongovett
approved these changes
Aug 25, 2022
| cmd.assert().success().stdout(predicate::str::contains(indoc! {r#" | ||
| @custom-media --foo print; | ||
| "#})); | ||
|
|
Member
There was a problem hiding this comment.
For next time, you could also have added this as a unit test - they are slightly easier to write and live in src/lib.rs. This is also fine though!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #258
Adds a semicolon at the end of the
@custom-mediadeclaration.@devongovett thank you for pointing me to the right file!