Skip to content

Chore: fix wrong url into TypeScript definition file in README#33

Merged
devongovett merged 1 commit intoparcel-bundler:masterfrom
Shinyaigeek:chore/fix-typescript-type-definition-url
Jan 10, 2022
Merged

Chore: fix wrong url into TypeScript definition file in README#33
devongovett merged 1 commit intoparcel-bundler:masterfrom
Shinyaigeek:chore/fix-typescript-type-definition-url

Conversation

@Shinyaigeek
Copy link
Contributor

@Shinyaigeek Shinyaigeek commented Jan 9, 2022

Motivation 🔥

Hi ! 👋

I noticed the link into TypeScript definitions in "From JavaScript" section is wrong. The relative path in README.md is resolved with branch prefix automatically, so blob/master/path is resolved to https://github.com/org/repo/blob/master/blob/master/path.

FYI: https://github.blog/2013-01-31-relative-links-in-markup-files/

I fixed this. In the first place, the rule of relative path of GitHub is difficult to understand, so I decided to specify it with an absolute path.

@height
Copy link

height bot commented Jan 9, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@devongovett devongovett merged commit 7d560e3 into parcel-bundler:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants