fix: Correctly enclose negated downleveled interval media queries in parens (Alternative A)#333
Closed
LeoniePhiline wants to merge 2 commits intoparcel-bundler:masterfrom
Closed
Conversation
…parens (Alternative A)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is alternative A to #332 for fixing #320.
See #332 for the main proposal. To me, the main proposal is preferable.
This alternative approach uses a boolean flag on the
Printer. This is sound here, as the flag is only applied when renderingMediaCondition::Featureinside aMediaCondition::Not. The former does not currently contain nested items which would interact with the flag.However, the solution could easily become unsound when code is changed such that the code path recurses. In that case, a stack of flags for each layer would be required, as not all nested items should automatically be considered (direct) children of a negated media condition.
Soundness is not enforced by the type system.
To my mind, the original approach at #332 is preferable, as it leverages the existing types for expanding the media feature interval.