Add sourcemap feature#372
Conversation
|
Seeing around 15% savings in compile times on my machine when running This PR gets BeforeAround AfterAround |
1aa56ac to
dab1a3b
Compare
|
|
||
| printer.sources = Some(&self.sources); | ||
| #[cfg(feature = "sourcemap")] | ||
| { |
There was a problem hiding this comment.
Conditionally compiling expressions isn't stable, so needed to wrap this in a block.
Cargo.toml
Outdated
| @@ -29,12 +29,13 @@ crate-type = ["rlib"] | |||
| [features] | |||
| default = ["bundler", "grid", "nodejs"] | |||
There was a problem hiding this comment.
I think we should probably add "sourcemap" to the default features. I guess the node bindings are getting it through "bundler" right now, though they kinda use it directly too even without the bundler.
There was a problem hiding this comment.
Ok great. Just force pushed a commit with sourcemap as an explicitly default feature
This commit introduces the "sourcemap" feature. Users that do not need sourcemaps can disable this feature and save roughly 15% on compile times. Related to parcel-bundler#357
dab1a3b to
5313652
Compare


This commit introduces the "sourcemap" feature.
Users that do not need sourcemaps can disable this feature and save
roughly 15% on compile times.
Related to #357