Add visitor support to WASM build via napi-wasm#373
Merged
devongovett merged 14 commits intomasterfrom Dec 29, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for visitors to the WASM build. Rather than reimplement this all again for wasm-bindgen and maintain two versions, I decided to shim the napi API for WASM so we can use the same implementation everywhere. That resulted in the napi-wasm project. This updates lightningcss to use it.
It also updates the playground to support custom visitors, and uses code mirror for a nicer editing experience.
Example