CLI support for piping#380
Merged
devongovett merged 2 commits intoparcel-bundler:masterfrom Jan 3, 2023
Merged
Conversation
src/main.rs: made input_file optional and use stdin and a fake name if it's None Cargo.toml: added new cli dependency on atty for detecting pipe rust-toolchain.toml: bumped version of Rust for stable std::io::read_to_string tests/cli_integration_tests.rs: removed test for no_input_file
devongovett
requested changes
Jan 2, 2023
|
Is there a test case for stdin input? It doesn't seem to work for me, unless I'm doing something wrong :( |
Contributor
Author
|
What did you try? I just built the latest version and this seems to work for me. If it detects that STDIN has not been redirected, it gives an error rather than silently wait for input. |
|
@oylenshpeegul Ignore my stupidity, sorry :) It works flawlessly! |
Contributor
Author
|
No worries! Have a nice day. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #375
src/main.rs: made input_file optional and use stdin and a fake name if it's None
Cargo.toml: added new cli dependency on atty for detecting pipe
rust-toolchain.toml: bumped version of Rust for stable std::io::read_to_string
tests/cli_integration_tests.rs: removed test for no_input_file