Skip to content

Invalid value handling #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vladinator1000 wants to merge 3 commits into from
Closed

Invalid value handling #449

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9752680
add invalid value test
vladinator1000 Mar 22, 2023
1d659e1
add error location
vladinator1000 Mar 22, 2023
6abbf27
rename test
vladinator1000 Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions tests/test_invalid_input.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
use lightningcss::{
error::{Error, ErrorLocation, ParserError},
rules::Location,
stylesheet::{ParserOptions, StyleSheet},
};

#[test]
fn value_missing_closing_brace() {
let input = r#"
.corrupt {
color: hsla(120, 62.32%;
}
"#;

let parsed = StyleSheet::parse(input, ParserOptions::default()).unwrap_err();
Copy link
Author

@vladinator1000 vladinator1000 Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test currently fails, because the parsing result is Ok when it should be an error.

---- value_missing_closing_brace stdout ----
thread 'value_missing_closing_brace' panicked at 'called `Result::unwrap_err()` on an `Ok` value: StyleSheet { rules: CssRuleList([Style(StyleRule { selectors: SelectorList([Selector(.corrupt, specificity = 0x400)]), vendor_prefix: (empty), declarations: DeclarationBlock { important_declarations: [], declarations: [Unparsed(UnparsedProperty { property_id: Color, value: TokenList([Function(Function { name: Ident("hsla"), arguments: TokenList([Token(Number { has_sign: false, value: 120.0, int_value: Some(120) }), Token(Comma), Token(Percentage { has_sign: false, unit_value: 0.6232, int_value: None }), Token(Semicolon), Token(WhiteSpace(" ")), Token(CloseCurlyBracket)]) })]) })] }, rules: CssRuleList([]), loc: Location { source_index: 0, line: 1, column: 5 } })]), sources: [""], source_map_urls: [None], options: ParserOptions { filename: "", nesting: false, custom_media: false, css_modules: None, source_index: 0, error_recovery: false, warnings: None } }', tests/test_invalid_input.rs:15:67


let expected = Error {
kind: ParserError::InvalidValue,
loc: Some(ErrorLocation::new(
Location {
line: 0,
column: 23,
source_index: 0,
},
"".to_string(),
)),
};

assert_eq!(parsed.to_string(), expected.to_string());
}