Support bundle and bundleAsync APIs in wasm builds#583
Merged
devongovett merged 4 commits intomasterfrom Sep 11, 2023
Merged
Conversation
Faster to run wasm-opt on the smaller file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #277
This uses Emscripten/Binaryen's Asyncify transform to allow synchronous WASM code to call asynchronous JavaScript code. That way a custom resolver can be passed in to read files. That avoids it needing to be multithreaded, which is complicated in WASM (without WASI). The node flavor has a default resolver that reads files using node's filesystem. The browser version will require a custom resolver to be passed in.