feat: support CJS output for wasm build#643
Merged
devongovett merged 2 commits intoparcel-bundler:masterfrom Jan 8, 2024
kirjavascript:cjs
Merged
feat: support CJS output for wasm build#643devongovett merged 2 commits intoparcel-bundler:masterfrom kirjavascript:cjs
devongovett merged 2 commits intoparcel-bundler:masterfrom
kirjavascript:cjs
Conversation
Contributor
kirjavascript
commented
Dec 8, 2023
- Brings WASM builds feature parity with exports from native builds
- Adds esbuild to convert to CJS (similar to other parcel repos)
devongovett
reviewed
Jan 8, 2024
| `${dir}/wasm/wasm-node.mjs`, | ||
| `${dir}/wasm/index.mjs`, | ||
| ], | ||
| bundle: true, |
Member
There was a problem hiding this comment.
I think we should exclude node_modules here so that napi-wasm doesn't get bundled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.