Disable transform optimizations#694
Merged
devongovett merged 1 commit intoparcel-bundler:masterfrom Mar 7, 2024
Merged
Conversation
devongovett
approved these changes
Mar 7, 2024
sungik-choi
referenced
this pull request
in channel-io/bezier-react
Mar 18, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [lightningcss](https://togithub.com/parcel-bundler/lightningcss) | [`1.24.0` -> `1.24.1`](https://renovatebot.com/diffs/npm/lightningcss/1.24.0/1.24.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>parcel-bundler/lightningcss (lightningcss)</summary> ### [`v1.24.1`](https://togithub.com/parcel-bundler/lightningcss/releases/tag/v1.24.1) [Compare Source](https://togithub.com/parcel-bundler/lightningcss/compare/v1.24.0...v1.24.1) - Disabled CSS `transform` optimizations using `matrix()`, which could break transitions and animations. – [https://github.com/parcel-bundler/lightningcss/pull/694](https://togithub.com/parcel-bundler/lightningcss/pull/694) - Merge `@supports` declarations with the same property (minus vendor prefix) and value – [`6bd2761`](https://togithub.com/parcel-bundler/lightningcss/commit/6bd2761badb9d5434783acffcae35ef6c3311e06) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on Monday after 10am before 7pm" in timezone Asia/Seoul, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/channel-io/bezier-react). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI0NS4wIiwidGFyZ2V0QnJhbmNoIjoiYWxwaGEifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables transform optimizations for now because they are causing issues for CSS transitions and
@keyframes. This is because currently minification only minifies if the result is actually shorter.There are situations where this is not the case:
Gets optimized to:
The issue is that this means that the
transformproperty is no longer animatable because different steps in the keyframes have different properties.I didn't just drop the code, but commented it out with a TODO to the linked issue so that it's easier to re-enable it later.
Fixes: #288