feat: Add a lint for unsupported CSS Module selector#784
Merged
devongovett merged 9 commits intoparcel-bundler:masterfrom Aug 2, 2024
Merged
feat: Add a lint for unsupported CSS Module selector#784devongovett merged 9 commits intoparcel-bundler:masterfrom
devongovett merged 9 commits intoparcel-bundler:masterfrom
Conversation
mischnic
reviewed
Aug 1, 2024
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
devongovett
reviewed
Aug 1, 2024
Co-authored-by: Devon Govett <devongovett@gmail.com>
Co-authored-by: Devon Govett <devongovett@gmail.com>
devongovett
approved these changes
Aug 2, 2024
Member
devongovett
left a comment
There was a problem hiding this comment.
Thanks! Will do a release tomorrow.
Contributor
Author
|
@devongovett Did you do a release? |
Member
|
crates are now published. I ran into a CI build issue for the npm binaries that I still need to fix, but crates should be usable. |
Contributor
Author
|
Thank you! |
|
Sorry to bother, but this should not have been a patch semver bump but a minor bump, the addition of a new variant to a public enum is breaking some builds. |
Member
|
Ah sorry about that, I didn't realize it wasn't pinned. Not sure I can fix it at this point. Will be more careful in the future. |
kdy1
added a commit
to vercel/next.js
that referenced
this pull request
Aug 7, 2024
### What? Update `lightningcss` crate of next.js ### Why? To apply parcel-bundler/lightningcss#784 and parcel-bundler/lightningcss#783 ### How? - Closes PACK-2933 - Closes PACK-3100 - Closes #66191 - Closes #64299
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
### What? Update `lightningcss` crate of next.js ### Why? To apply parcel-bundler/lightningcss#784 and parcel-bundler/lightningcss#783 ### How? - Closes PACK-2933 - Closes PACK-3100 - Closes #66191 - Closes #64299
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: vercel/next.js#64299
I made it a parse error because the specification about it is ambiguous thus it's better to bail out.