Skip to content

fix: correct sm breakpoint size to match the one from flex-layout as intended #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philmtd merged 1 commit into from
May 9, 2023
Merged

fix: correct sm breakpoint size to match the one from flex-layout as intended #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion documentation/docs/attribute-selectors/show-hide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ what you wanted.
## Example

```html
<div data-show-gt-sm>I will only be visible on screens wider than 969px.</div>
<div data-show-gt-sm>I will only be visible on screens wider than 959px.</div>
```

:::info
Expand Down
2 changes: 1 addition & 1 deletion documentation/docs/class-selectors/show-hide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ With `mediaQueryName` being the name of one of the [available media queries](../
## Example

```html
<div class="show-gt-sm">I will only be visible on screens wider than 969px.</div>
<div class="show-gt-sm">I will only be visible on screens wider than 959px.</div>
```

:::info
Expand Down
2 changes: 1 addition & 1 deletion documentation/docs/responsive.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ The fx-layout media queries use the following breakpoints:
| Name | Breakpoint |
|------|------------|
| xs | 599px |
| sm | 969px |
| sm | 959px |
| md | 1279px |
| lg | 1919px |
| xl | 5000px |
Expand Down
2 changes: 1 addition & 1 deletion documentation/versioned_docs/version-3.0/attribute-selectors/show-hide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ what you wanted.
## Example

```html
<div data-show-gt-sm>I will only be visible on screens wider than 969px.</div>
<div data-show-gt-sm>I will only be visible on screens wider than 959px.</div>
```

:::info
Expand Down
2 changes: 1 addition & 1 deletion documentation/versioned_docs/version-3.0/class-selectors/show-hide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ With `mediaQueryName` being the name of one of the [available media queries](../
## Example

```html
<div class="show-gt-sm">I will only be visible on screens wider than 969px.</div>
<div class="show-gt-sm">I will only be visible on screens wider than 959px.</div>
```

:::info
Expand Down
2 changes: 1 addition & 1 deletion documentation/versioned_docs/version-3.0/responsive.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ The fx-layout media queries use the following breakpoints:
| Name | Breakpoint |
|------|------------|
| xs | 599px |
| sm | 969px |
| sm | 959px |
| md | 1279px |
| lg | 1919px |
| xl | 5000px |
Expand Down
2 changes: 1 addition & 1 deletion src/lib/mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
// Media Sizes
// flex-layout breakpoints
$xs: 599px;
$sm: 969px;
$sm: 959px;
$md: 1279px;
$lg: 1919px;
$xl: 5000px;
Expand Down
8 changes: 4 additions & 4 deletions test/media-sizes.spec.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
}
}
@include true.expect {
@media screen and (min-width: 600px) and (max-width: 969px) {
@media screen and (min-width: 600px) and (max-width: 959px) {
color: coral;
}
}
Expand All @@ -38,7 +38,7 @@
}
}
@include true.expect {
@media screen and (min-width: 970px) and (max-width: 1279px) {
@media screen and (min-width: 960px) and (max-width: 1279px) {
color: coral;
}
}
Expand Down Expand Up @@ -96,7 +96,7 @@
}
}
@include true.expect {
@media screen and (max-width: 969px) {
@media screen and (max-width: 959px) {
color: coral;
}
}
Expand Down Expand Up @@ -154,7 +154,7 @@
}
}
@include true.expect {
@media screen and (min-width: 970px) {
@media screen and (min-width: 960px) {
color: coral;
}
}
Expand Down